Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #2590

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Update Dockerfile #2590

merged 2 commits into from
Jun 23, 2022

Conversation

jt0dd
Copy link
Contributor

@jt0dd jt0dd commented May 23, 2022

Description

Solves #2515 and #2579

Fixes an error where a Windows user somehow modifies update-agents.sh (this can happen indirectly, because I was having this error without modifying the file) resulting in Windows line endings breaking Linux interpretation of the file.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I've tested it on my Windows 11 machine, launching the Docker version of the project.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

I'm not sure how to create a unit test for a Dockerfile

Solves mitre#2515 and mitre#2579

Fixxes an error where a Windows user somehow modifies update-agents.sh (this can happen indirectly, because I was having this error without modifying the file) resulting in Windows line endings breaking Linux interpretation of the file.
@jt0dd
Copy link
Contributor Author

jt0dd commented May 23, 2022

I don't think this can hurt, especially since it's tied to the WIN_BUILD argument.

@github-actions
Copy link

This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.
The tests are passing but workflows are failing because the fork doesn't have our SonarCloud token.

@clenk clenk requested a review from CDJellen June 22, 2022 14:47
@elegantmoose
Copy link
Contributor

Thank you for your contribution @jt0dd

@elegantmoose elegantmoose merged commit d4ab84c into mitre:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants