-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIRTS-3996 Add everything adversary #2563
Conversation
* Create everything adversary during startup * Update everything adversary when abilities are created or deleted via UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wohoo! Your first PR -- thanks for contributing!
@sgianvecchio super clean. I still need to test locally. |
I'll echo @elegantmoose 's comments, the code is clean and parsimonious. In performing some local testing, I've noticed a few behaviors which may be worth verifying and documenting.
Additional Thoughts: If, in the future, it is determined that there is a better place for these changes to live, we can discuss options. For now, the PR looks great to me, and I have identified no issues or edge cases in testing. Thank you for this excellent first PR @sgianvecchio ! |
Please retry analysis of this Pull-Request directly on SonarCloud. |
This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days |
This issue is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Please retry analysis of this Pull-Request directly on SonarCloud. |
Kudos, SonarCloud Quality Gate passed! |
Description
This change adds a new "everything" adversary with all adversary abilities. The everything adversary is automatically created during startup and updated whenever abilities are created or deleted via the UI.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: