Operations select dead agent bug in add potential link menu #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere if first agent is dead, does not let user select a different agent when creating a command
iguannalin
requested review from
argaudreau and
wbooth
and removed request for
argaudreau
Codecov Report
@@ Coverage Diff @@
## master #2344 +/- ##
=======================================
Coverage 72.60% 72.60%
=======================================
Files 110 110
Lines 7946 7946
=======================================
Hits 5769 5769
Misses 2177 2177 Continue to review full report at Codecov.
|
argaudreau
previously approved these changes
Nov 1, 2021
argaudreau
requested review from
cyber-arsenull
and removed request for
wbooth
cyber-arsenull
suggested changes
Nov 9, 2021
Remove unnecessary assignment Co-authored-by: Jordan Hanna <4370241+cyber-arsenull@users.noreply.github.com>
argaudreau
approved these changes
Nov 9, 2021
cyber-arsenull
approved these changes
Nov 9, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
cyber-arsenull
added a commit
that referenced
this pull request
Dec 28, 2021
* Fix opacity for view command buttons in operation links; Fixed bug where if first agent is dead, does not let user select a different agent when creating a command * Update templates/operations.html Remove unnecessary assignment Co-authored-by: Jordan Hanna <4370241+cyber-arsenull@users.noreply.github.com> Co-authored-by: Adam Gaudreau <argaudreau@users.noreply.github.com> Co-authored-by: Jordan Hanna <4370241+cyber-arsenull@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed bug where if first agent is dead, does not let user select a different agent when creating a command
Removed opacity styling on view command buttons in operation links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: