Skip to content

[VIRTS-2881] Health API v2 Pytests #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 6, 2021

Conversation

bleepbop
Copy link
Contributor

@bleepbop bleepbop commented Oct 5, 2021

Description

Pytests for v2 Health API. Note: there is only one endpoint, and it is unauthenticated. Both tests (with authorization and without) should pass.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Verified tests pass for multiple versions of python using tox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [NA] I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #2305 (86c3588) into master (cc7e46e) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
+ Coverage   72.15%   72.27%   +0.11%     
==========================================
  Files         103      105       +2     
  Lines        7719     7748      +29     
==========================================
+ Hits         5570     5600      +30     
+ Misses       2149     2148       -1     
Impacted Files Coverage Δ
app/api/v2/handlers/health_api.py 100.00% <0.00%> (ø)
app/api/v2/schemas/caldera_info_schemas.py 100.00% <0.00%> (ø)
app/service/app_svc.py 50.86% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7e46e...86c3588. Read the comment docs.

@bleepbop bleepbop requested review from uruwhy and emmanvg October 5, 2021 17:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wbooth wbooth merged commit d742b2b into master Oct 6, 2021
@wbooth wbooth deleted the bleepbop/VIRTS-2881/health-v2-api-pytest branch October 6, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants