virts-2891 - Planner parsing error checking #2275

ArtificialErmine · 2021-09-22T17:59:15Z

Description

This change makes it possible for parsers to return an error code that signals the failure of a link based on the return, regardless of the return code of the link. This functionality is not automatic, and needs to be manually triggered from parsers to occur. For an example, see the atomic example.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This has been tested in a AWS environment with Alice 2.0, as well as with the full battery of tests.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
[NA] I have made corresponding changes to the documentation
[NA] I have added tests that prove my fix is effective or that my feature works

failed based on the output of the parser

codecov · 2021-09-22T22:33:29Z

Codecov Report

Merging #2275 (70f9852) into master (d742b2b) will decrease coverage by 0.13%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master    #2275      +/-   ##
==========================================
- Coverage   72.27%   72.14%   -0.14%     
==========================================
  Files         105      106       +1     
  Lines        7748     7790      +42     
==========================================
+ Hits         5600     5620      +20     
- Misses       2148     2170      +22

Impacted Files	Coverage Δ
app/objects/secondclass/c_link.py	`86.36% <16.66%> (-1.55%)`	⬇️
app/utility/base_parser.py	`51.35% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d742b2b...70f9852. Read the comment docs.