Skip to content

Homepage Stories & Events layout fixes #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Conversation

jonkafton
Copy link
Contributor

@jonkafton jonkafton commented Jun 17, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/4477

Description (What does it do?)

  1. Card default and hover state design updates were done in previous PR (Learning Resource cards, list view #1054).

  2. Fixes the bottom horizontal alignment on the News and Events Homepage section cards.

3+4. vertically centers the title in the event cards.

Screenshots (if appropriate):

image

How can this be tested?

Load the Homepage and check that the above items are addresses and the layout matches the designs.

Additional Context

  • Also addresses issue where the footer text and action buttons collide in the small variant cards. Not solved necessarily, but "Start:" label removed and month abbreviated to 3 letters (small mode only).

Previously:
image

  • Adds the facility to pass styles to override the Card slots.

@jonkafton jonkafton changed the title Pass slot props to Card. Adjust css to align and match designs Homepage Stories & Events layout fixes Jun 17, 2024
@shanbady shanbady self-requested a review June 17, 2024 18:27
@shanbady shanbady self-assigned this Jun 17, 2024
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style changes Look good. one discrepancy i saw was that the news events did not have any action buttons as shown in the figma. might be outside the scope of this ticket but is this expected?

@jonkafton
Copy link
Contributor Author

one discrepancy i saw was that the news events did not have any action buttons as shown in the figma. might be outside the scope of this ticket but is this expected?

To my knowledge news/events don't have action buttons (the learning resource "add to user list" and admin "add to learning path" don't apply).

Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case looks like there is just the test to fix before merging

@jonkafton jonkafton merged commit 98293d9 into main Jun 17, 2024
12 checks passed
@jonkafton jonkafton deleted the jk/4477-stories-ui-fixes branch June 17, 2024 21:10
@odlbot odlbot mentioned this pull request Jun 18, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants