-
Notifications
You must be signed in to change notification settings - Fork 3
breadcrumbs component #1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
breadcrumbs component #1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f746c2e
to
20adbea
Compare
20762cc
to
967aef7
Compare
d31cb9a
to
2b598a5
Compare
…vercolor props of "lightRed, darkGray2 or white" to match the names of colors actually in the theme, also allowing hover color to be specified
…r so it doesn't erroneously pick up the breadcrumb link with the same name
aaf83c0
to
3bf426a
Compare
shanbady
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as needed. LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4593
Description (What does it do?)
This PR adds a new
Breadcrumbs
component tool-components
. This component takes a variant of "light" or "dark," list of dicts in theancestors
property, each with anhref
andlabel
property as well as a value forcurrent
which is just a string labeling the current page. The component is implemented on the various pages that use breadcrumbs.Screenshots (if appropriate):
How can this be tested?
mit-open
on this branch