Skip to content

breadcrumbs component #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 17, 2024
Merged

breadcrumbs component #1089

merged 14 commits into from
Jun 17, 2024

Conversation

gumaerc
Copy link
Contributor

@gumaerc gumaerc commented Jun 14, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/4593

Description (What does it do?)

This PR adds a new Breadcrumbs component to ol-components. This component takes a variant of "light" or "dark," list of dicts in the ancestors property, each with an href and label property as well as a value for current which is just a string labeling the current page. The component is implemented on the various pages that use breadcrumbs.

Screenshots (if appropriate):

image
image
image
image

How can this be tested?

@gumaerc gumaerc added the Needs Review An open Pull Request that is ready for review label Jun 17, 2024
@shanbady shanbady self-requested a review June 17, 2024 17:29
Copy link
Contributor

@shanbady shanbady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as needed. LGTM

@shanbady shanbady added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Jun 17, 2024
@gumaerc gumaerc merged commit e051fea into main Jun 17, 2024
12 checks passed
@gumaerc gumaerc mentioned this pull request Jun 17, 2024
@odlbot odlbot mentioned this pull request Jun 18, 2024
13 tasks
@rhysyngsun rhysyngsun deleted the cg/breadcrumb-component branch February 7, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants