Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column def pro #1272

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Column def pro #1272

merged 2 commits into from
Mar 14, 2024

Conversation

aarondr77
Copy link
Member

@aarondr77 aarondr77 commented Mar 14, 2024

Description

Makes column definitions require a liscence

Testing

Test it with the sample app

Documentation

No.

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 6:02pm

Copy link
Contributor

@naterush naterush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, then LGTM

@@ -253,6 +253,9 @@ def __init__(
if not is_running_test() and not is_enterprise() and self.user_defined_editors is not None and len(self.user_defined_editors) > 0:
raise ValueError("editors are only supported in the enterprise version of Mito. See Mito plans https://www.trymito.io/plans")

if not is_running_test() and not is_pro() and column_definitions is not None:
raise ValueError("column definitions are only supported in the enterprise version of Mito. See Mito plans https://www.trymito.io/plans")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you wanna update the error message to say Pro?

@aarondr77 aarondr77 merged commit 77c466d into dev Mar 14, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants