Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I re-wrote a substantial chunk of the code-base for my own purposes and am opening this PR primarily in case there were any components you would like to reuse - please feel free to close it if not.
Primary changes
A few notes
.astype(str)
to training data as this mapsnp.nan -> 'nan'
. The downstream assumptions producingbag_of_$(x)
, paragraph vectors, and word_embeddings are all broken in the presence of missing values. The default sherlock model with correctly handled missing values now fails for sequences with missing values and could benefit from re-training.Thanks for this great resource!