Build env modernization #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix build error
yhirano
commented
Mar 3, 2025
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-bin.zip |
There was a problem hiding this comment.
I upgraded Gradle to build with the new OpenJDK.
The old OpenJDK does not support Apple Silicon, making development difficult.
yhirano
commented
Mar 3, 2025
| } | ||
| dependencies { | ||
| compile 'com.android.support:support-v4:18.0.0' | ||
| plugins { |
There was a problem hiding this comment.
Update build.gradle for modern Android Gradle Plugin.
yhirano
commented
Mar 3, 2025
| @@ -167,7 +167,7 @@ public FlipView(Context context, AttributeSet attrs, int defStyle) { | |||
| R.styleable.FlipView); | |||
|
|
|||
| // 0 is vertical, 1 is horizontal | |||
| mIsFlippingVertically = a.getInt(R.styleable.FlipView_orientation, | |||
| mIsFlippingVertically = a.getInt(R.styleable.FlipView_android_orientation, | |||
yhirano
commented
Mar 3, 2025
There was a problem hiding this comment.
Move files for modern Android Gradle Plugin.
yhirano
commented
Mar 3, 2025
| <enum name="vertical" value="0"/> | ||
| <enum name="horizontal" value="1"/> | ||
| </attr> | ||
| <attr name="android:orientation" /> |
yhirano
commented
Mar 3, 2025
| dependencies { | ||
| compile project(':library') | ||
| compile 'com.android.support:support-v4:18.0.0' | ||
| plugins { |
There was a problem hiding this comment.
Update build.gradle for modern Android Gradle Plugin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build android-FlipView in a modern environment.