Skip to content

Should check for SoftDeletes traits in parent classes also. #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Should check for SoftDeletes traits in parent classes also. #54

wants to merge 1 commit into from

Conversation

hhjcz
Copy link

@hhjcz hhjcz commented Oct 15, 2014

When SoftDeletes trait is used in superclass, the isSoftDeletable doesn't detect it. This fix works for me.

@hhjcz hhjcz force-pushed the feature/softdel-parents-traits-fix branch from 04e448c to f4e82ed Compare October 20, 2014 07:19
@hhjcz hhjcz mentioned this pull request Oct 20, 2014
Open
@hhjcz hhjcz force-pushed the feature/softdel-parents-traits-fix branch from f4e82ed to 9a5e4e8 Compare October 20, 2014 08:02
@hhjcz hhjcz force-pushed the feature/softdel-parents-traits-fix branch from 9a5e4e8 to fd3917f Compare October 20, 2014 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hhjcz