Fix SoftDeletes for null values in the DB (not deleted entries). #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tweaked description of `clean` flag to make its usage clearer. - Made sure to do a `not` on the flag since `$saveMode = false` is what will clean out the database of unneeded assets. So, not providing the `--clean` flag will mean that we only update the tables that have changed and leave everything else as is. - Make sure the clean flag is used when actually updating the schema and not just used to get the SQL.
fix usage of saveMode via the clean flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function isDeleted for SoftDeletes returns true even if value of isDeleted is set to null. This fix changes the return value to false in this case.