Modify check-pr to support issue assignment requirement

[igalklebanov]

Hey 👋

Thanks for this initiative! 💪

Would be nice to also configure auto-close of pull requests from non-collaborators that either have no bound GitHub issue/s or the issues are not assigned to the pull request submitter's account.

I want to first review an issue, greenlight and assign it manually to a specific vouched account.

I want to avoid 2 or more vouched accounts submitting competing pull requests for the same issue. I want visibility on who is working on what. I want to delay work on certain parts of the system to avoid conflicts when necessary.

[DitherDude]

I have no control what-so-ever over this project in any way, but I'm a little bit confused over your post (don'b blame yourself I'm also tired). So to clarify:

1. user creates PR.
2. if (you are collaborator) -> skip/ignore/allow PR
3. otherwise if (PR does not have corrsponding issue) OR (PR author is not assigned an to said corresponding issue) -> close PR
4. otherwise wait for admin to delegate to another account/contributor?

And then I don't understand how your final paragraph relates to vouch as a project...

[igalklebanov]

otherwise if (PR does not have corrsponding issue) OR (PR author is not assigned an issue) -> close

PR author is not assigned an to corresponding issue.

And then I don't understand how your final paragraph relates to vouch as a project...

Vouch is a set of tools enabling a trust network. The end goal is maintainers not having to deal with a bunch of dumb slop drive by pull requests.

Vouched accounts can still produce a lot of pull requests (given the tooling today) and they can submit competing pull requests for the same issues. This is extra work for maintainers.

I believe assigning an account to an issue is a form of limited vouching. It can be combined with the core concept of this project in different ways.

One is to configure auto-closing of pull requests to also enforce the issue stuff - as described in original post.

Another could be to deny assigning issues to denounced accounts.

Another could be auto-assign issue to vouched accounts that ask to be assigned to an issue.

[DitherDude]

I see. I will update my prior comment.

[davidvasandani]

Go see every zed. Zzz****c

[igalklebanov]

@davidvasandani

Go see every zed. Zzz****c

excuse me?

[igalklebanov]

@DitherDude

otherwise wait for admin to delegate to another account/contributor?

Don't care. That's up to each project and its process. Some delegate, some review themselves.

[mitchellh]

Looks like we could actually support this with closingIssuesReferences via GraphQL and our Nu has the ability to query GraphQL already so yeah, this is possible.

I think this is actually two separate features:

1. check-pr should support something like --require-issue that just requires that some issue is referenced to be closed
2. check-pr should also support --require-issue-assignment that also requires at least one of the closed issues is assigned to the submitter.

Would this work?

[igalklebanov]

@mitchellh yeah that would work. Should I create separate issues for tracking?

#6 (comment) has 2 more feature ideas.

[mitchellh]

#6 (comment) has 2 more feature ideas.

I read the comment and not sure I see them. They sound covered by my proposals. What did I miss?

[mitchellh]

I pinned my comment as the answer here and changed the title. If there's other stuff to add I'll do so!