Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot access Discourse if user have changed username / email associated to their edx account #32

Open
brospars opened this issue May 7, 2019 · 4 comments · May be fixed by #35
Open

Comments

@brospars
Copy link

brospars commented May 7, 2019

If an user changes his username or email associated with their edx account, then he cannot access Discourse because of this.

Wouldn't it be possible to update his account instead of throwing an error ?

@kevinrobinson
Copy link
Contributor

kevinrobinson commented May 7, 2019

@brospars Thanks! In my limited experience, this hasn't been an issue, so that's why it's more conservative now. But that may be related to the particular courses, or that they've been smaller and we just haven't run into anyone changing their name yet. :)

If you want to submit a pull request changing this, please include links to EdX documentation and Discourse docs about this, as the plugin would have to make the same assumptions about which is the primary key and how changes are handled (eg, as in https://support.edx.org/hc/en-us/articles/115016004448-Can-I-change-my-edX-username- for EdX).

@brospars
Copy link
Author

brospars commented May 7, 2019

Yes Edx use the username as primary key, so this plugin could make the same assumption and if the email has changed then update it.

I'm leaving for some days but I will look into it next week

@kevinrobinson
Copy link
Contributor

@brospars Sounds good, pull requests welcome! 👍

I'm also happy to brainstorm on how to verify this is works correctly for the various edge cases, since there's a bunch of risk in deploying that I likely won't be able to verify myself.

brospars added a commit to brospars/discourse-edx-lti that referenced this issue Apr 26, 2021
@brospars brospars linked a pull request Apr 26, 2021 that will close this issue
@brospars
Copy link
Author

@kevinrobinson Hello just to let you know I've opened two PR would you mind taking a look ?

brospars added a commit to brospars/discourse-edx-lti that referenced this issue Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants