Add support for EXTERNAL_DEPENDENCIES=1 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a plan to move bedrock2 to dune? It supports composition in subfolders / submodules out of the box with no additional configuration |
That is a question for @samuelgruetter or @andres-erbsen I think. (I've never set up a dune build) |
|
Any objections to me merging this so we can make progress on coq/opam#2137 (comment)? |
JasonGross
force-pushed
the
external-deps
branch
from
d640754
to
28a8355
Compare
Now that it changes based on Makefile arguments we don't want to check it in.
JasonGross
force-pushed
the
external-deps
branch
from
28a8355
to
0361b5c
Compare
|
I'm going to merge this do so that it's possible to bench fiat-crypto at coq/coq#15860 (comment) |
|
Thanks for working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the scheme in bedrock2