Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload standalone binaries to release pages #1711

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

JasonGross
Copy link
Collaborator

@JasonGross JasonGross commented Nov 9, 2023

There's also some minimal testing to see that the binaries work without installing all the extra Coq infrastructure.

Presumably we should get #1625 working and upload only statically-linked elf binaries (+ mac & windows), not separate binaries for docker, debian, etc. Also TODO: figuring out if we need to do extra things to get Windows binaries working (probably?).

On top of #1710

@JasonGross JasonGross force-pushed the standalone-package-extra branch 8 times, most recently from 1c17c57 to 6a2a105 Compare November 11, 2023 23:41
@JasonGross JasonGross changed the title [WIP] Upload standalone binaries to release pages Upload standalone binaries to release pages Nov 11, 2023
@JasonGross JasonGross force-pushed the standalone-package-extra branch 5 times, most recently from bcd259a to efce731 Compare November 12, 2023 20:05
@JasonGross JasonGross marked this pull request as ready for review November 12, 2023 20:06
@JasonGross JasonGross marked this pull request as draft November 13, 2023 02:36
@JasonGross JasonGross force-pushed the standalone-package-extra branch 2 times, most recently from 2c57844 to 51546c5 Compare November 13, 2023 06:10
@JasonGross JasonGross marked this pull request as ready for review November 13, 2023 06:13
@JasonGross JasonGross enabled auto-merge (squash) November 13, 2023 06:13
@JasonGross
Copy link
Collaborator Author

Only dumpbin fails, I'm going to merge this and then fix it immediately after, I don't want to bother with another round of CI.

@JasonGross JasonGross merged commit 8b6191b into mit-plv:master Nov 13, 2023
27 of 29 checks passed
@JasonGross JasonGross deleted the standalone-package-extra branch November 13, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant