-
Notifications
You must be signed in to change notification settings - Fork 166
Reformat codebase and add pre-commit
#81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81179bc
to
a57dc9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'm curious, what's the advantage of doing it through pre-commit versus the old formatter workflow?
@CCInc, the advantages of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
084b0b7
4c7785a
to
ca14945
Compare
@CCInc @sandeepnmenon, this PR is ready for review. @kentangSJTU, I've tested the correctness of this version on semantic segmentation. It would be great if you could test it on object detection as well. |
4a235ba
to
7aa420d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I love how clean the pytorch API is now.
pre-commit
for continuous integrationpre-commit
304c4d8
to
562b385
Compare
562b385
to
0faa926
Compare
This PR reformats the codebase and integrates
pre-commit
for continuous integration. Contributors can first activate it locally bypre-commit install
, which will then be triggered automatically atgit commit
to check, fix and reformat the commit.