Fix Hadamard gate docstrings and type hints#317
Open
yurekami wants to merge 1 commit into
Open
Conversation
- hadamard(): Change wires type from Union[List[int], int] to int (single-qubit gate) - shadamard(): Change wires type from Union[List[int], int] to int (single-qubit gate) - chadamard(): Change wires type to List[int] and update docstring to clarify it's a controlled gate requiring 2 qubits - Fix bug: chadamard() was using undefined mat_dict instead of _hadamard_mat_dict Fixes mit-han-lab#306 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hadamard()andshadamard()docstrings: Changedwirestype fromUnion[List[int], int]tointsince these are single-qubit gates (num_wires = 1)chadamard()docstring: Clarified it's a controlled gate requiring a list of 2 qubits (control and target)chadamard()was referencing undefinedmat_dictinstead of_hadamard_mat_dictTest plan
num_wiresattribute in class definitionsFixes #306
🤖 Generated with Claude Code