feat: enable no_std compilation and check it in CI#93
Open
JoseSK999 wants to merge 2 commits intomit-dci:mainfrom
Open
feat: enable no_std compilation and check it in CI#93JoseSK999 wants to merge 2 commits intomit-dci:mainfrom
no_std compilation and check it in CI#93JoseSK999 wants to merge 2 commits intomit-dci:mainfrom
Conversation
This commit adds two new dependencies that are needed for `no_std` support: `hashbrown` (`HashMap` alternative) and `bitcoin_io` (`io` trait and type replacements). The `AccumulatorHash` trait bounds depend on whether we use `std` or `no_std` now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new dependencies that are needed for
no_stdsupport:hashbrown(HashMapalternative) andbitcoin_io(iotrait and type replacements).The
AccumulatorHashtrait bounds depend on whether we usestdorno_stdnow.Note
This seems to work but perhaps we should add a feature powerset CI check to ensure all 4 combinations work fine for clippy and testing.
The
preludelist is fromfloresta-common, I think I can trim a couple of these imports.