Serde: use hex encoding for BitcoinNodeHash when (de)serializer is human-readable #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
So. With this, rather than a vector of integers like [242, 80, 99...] we would get a hexadecimal ( |
Ash-L2L
force-pushed
the
2025-08-07-serde-human-readable
branch
from
5884cce to
ef2904c
Compare
|
Added tests! |
Collaborator
|
Not sure about the MSRV bump, we follow rust-bitcoin's for ecosystem compatibility. |
Ash-L2L
force-pushed
the
2025-08-07-serde-human-readable
branch
from
e5a1f12 to
8b3fb3b
Compare
Contributor
Author
Updated to only bump rust version for the CI tests. The version bump is only required for dev-dependencies, the crate will still build on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be smaller with
hex-conservative::serde, but unfortunately thebitcoin-hashes/serdefeature does not enablehex-conservative/serde. Addinghex-conservativeas a direct dependency in order to enable the feature would require manually matching the version ofhex-conservativeto the version used inbitcoin-hashes.