Skip to content

Conversation

@amenasria
Copy link
Contributor

This PR adds:

  • A precommit hook running ruff, pyright and mypy on commit modifications.
  • A CI workflow running ruff, pyright and mypy on all files in the folders. It does not run on the examples folder yet

The folders we're linting are:

  • examples/
  • src/mistralai_private/extra/
  • src/mistralai_private/_hooks/

@amenasria amenasria requested a review from GaspardBT May 26, 2025 14:30
Copy link
Contributor

@jean-malo jean-malo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amenasria why not a makefile and / or uv scripts like in our other repos?

@amenasria
Copy link
Contributor Author

@jean-malo I want to avoid using both uv and poetry, we'll move those when we'll move to uv.

For Makefile idk it would be weird to have that here.

@amenasria
Copy link
Contributor Author

For now we've been droppping bash files, so I'm keeping the bash files going.

@amenasria amenasria merged commit 69374e8 into main May 26, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants