Download button opens in new tab #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should work with the already existing "download" attribute. But the spec says this is only valid when the image is on the same domain. So my question is : how does your change behaves when the panorama is hosted on the same domain ? Does it still downloads the image ? |
|
Thanks for your feedback. And in fact I just checked and my edit works as expected when picture is hosted on same domain : download is started directly without opening new tab (like current behaviour) 😀 |
|
This feature/bug fix has been released in version 5.1.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to change the current download button in navbar behaviour, to open offered image download in a new tab instead of redirecting current tab to image. Also fixes a typo in button classname.
Merge request checklist