feat(gh): リリースノート自動更新プログラム #238
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Unreleasedを受け取る可能性がありそう？
repository dispatchも引数を取れるのでリリース日とリリースバージョン名は引数で取ったほうがいいかも
There was a problem hiding this comment.
Githubのchangelogはmasterブランチから取るようになってるので向こうのワークフローがちゃんとしてればunreleasedが来ることはないと思う
引数で取れるようにするのはやりたい
| if: steps.diff.outcome == 'failure' | ||
| run: | | ||
| set -x | ||
| git checkout -b update-release-notes |
|
だいたい直したかも |
anatawa12
approved these changes
Sep 27, 2024
Comment on lines
+38
to
+39
| - run: pnpm start ${{ env.VERSION != null && format('-v {0}', env.VERSION) || '' }} ${{ env.RELEASE_DATE != null && format('-d {0}', env.RELEASE_DATE) || '' }} | ||
| working-directory: scripts/changelog-auto-updater |
There was a problem hiding this comment.
VERSIONやRELEASE_DATEに$が含まれない限りこれでも問題ないんだけど、せっかく environment variable を使ってるなら普通に index.ts で process.env.を使っちゃったほうがインジェクションとかもないしシンプルな気もする
pnpm start時に環境変数無いときにエラーでもいい気もしています
There was a problem hiding this comment.
pnpm start時に環境変数無いときにエラーでもいい気もしています
引数でバージョンが指定されたらそれが最新バージョンがどうかのチェックが走るだけになっているのでなくても動くからそこまでしなくてもいいかな…と（最悪手動で回せるようにすることを考えると）
Co-authored-by: anatawa12 <anatawa12@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
misskey-dev/release-manager-actions#9
github actions初心者なので動くか要確認