Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emojisToShow filter #43

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Add emojisToShow filter #43

merged 2 commits into from
Feb 17, 2017

Conversation

tracker-common
Copy link

We would like to add an custom filter to only display certain emojis based upon their unified value. For Windows 7/IE 11, anything with skin tones, flags and zero width joiners look pretty bad (i.e. their fallback values), so we want to filter that out using emojisToShowFilter property that gets passed in.

  1. Search shouldn't show emojis that are filtered out.
  2. Categories shouldn't show up if everything from that category is filtered out. (For our case, we want to filter out flags)

Signed-off-by: Thomas Osugi tosugi@pivotal.io

Signed-off-by: Thomas Osugi <tosugi@pivotal.io>
@ELD
Copy link

ELD commented Feb 16, 2017

We introduced an accidental regression with the first commit on this branch. Clearing out the search bar wouldn't result in showing all emoji again. The new commit fixes that regression.

@EtienneLem
Copy link
Member

Gotcha, thanks! Will force myself to find some time to get around to merging these PRs 👍

@EtienneLem EtienneLem merged commit 262e894 into missive:master Feb 17, 2017
@EtienneLem
Copy link
Member

Works like a charm 👍 🤘

EtienneLem added a commit that referenced this pull request Feb 17, 2017
@tracker-common tracker-common deleted the custom-emoji-filter branch February 17, 2017 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants