Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve accessible page structure #296

Merged

Conversation

nolanlawson
Copy link

Makes some progress on #294

  • Remove emojilist i18n text and region, just let each category have its own region
  • Add a region for the entire emoji picker, same as the title shown in the preview bar
  • Add a region for the search, using the same label as the placeholder for the input
  • Make the preview aria-hidden since it is decorative

This may still be better with headers rather than regions, but since we can't know how emoji-mart will be hosted on a page, we can't know whether to use h1 vs h2, etc. So regions seem safer to me, but admittedly I'm not an expert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant