Fixed bug where selecting the first emoji search result with the ENTER KEY ignores skin tone selection #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where selecting the first emoji search result with the ENTER key ignores skin-tone selection. This bug was due to the fact that the emojis in a
Category
are rendered asNimbleEmoji
, where skin-tone data and other properties are populated viagetSanitizedData
(this data is not present in theCategory
's emoji). Clicking an emoji therefore worked as expected since the click triggered theNimbleEmoji
'shandleClick
function which calledgetSanitizedData
. Pressing the enter key, however, triggered theNimblePicker
'shandleKeyDown
function which simply returned the first emoji inSEARCH_CATEGORY
(thus lacking the skin-tone data). ImportedgetSanitizedData
fromutils
and called it inhandleKeyDown
to resolve the issue. Please let me know if you would like any more information or if changes are required to match coding style.