Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug where selecting the first emoji search result with the ENTER KEY ignores skin tone selection #270

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

dwijesingheWR
Copy link

Fixed bug where selecting the first emoji search result with the ENTER key ignores skin-tone selection. This bug was due to the fact that the emojis in a Category are rendered as NimbleEmoji, where skin-tone data and other properties are populated via getSanitizedData (this data is not present in the Category's emoji). Clicking an emoji therefore worked as expected since the click triggered the NimbleEmoji's handleClick function which called getSanitizedData. Pressing the enter key, however, triggered the NimblePicker's handleKeyDown function which simply returned the first emoji in SEARCH_CATEGORY (thus lacking the skin-tone data). Imported getSanitizedData from utils and called it in handleKeyDown to resolve the issue. Please let me know if you would like any more information or if changes are required to match coding style.

@dwijesingheWR dwijesingheWR changed the title Fixed bug where selecting the first emoji search result with the ENTER KY ignores skin tone selection Fixed bug where selecting the first emoji search result with the ENTER KEY ignores skin tone selection Feb 13, 2019
@nolanlawson
Copy link

Confirmed via manual testing that this fixes the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants