Package size reduced from 87.35 KB to 79.43 KB

[bniwredyc]

No description provided.

[ai]

@bniwredyc can you show size-limit --why results? Did we remove all core-js?

[ai]

@EtienneLem are you OK with updating webpack? (I think latest webpack is always better)

[bniwredyc]

@ai you mean this picture?

and yes, no core-js left.
The thing is that babel uses core-js to polyfill some of es2015 features e.g. Symbols.
To do to it babel requires typeof helper:

which in its turn requires core-js module:

Also there were other cases where core-js was required, but I replaced babel helpers to less complex ones (e.g. without support of defineProperty for IE8).

[ai]

Great!

@EtienneLem this PR is last part of size optimization, which I promised you

[EtienneLem]

Thanks both of you. I want to do a thorough review before merging, but after that I’ll finally be ready to prepare a new release!

[EtienneLem]

Everything seems to be working, I’m however getting this size:

Did I miss something? 🤔

[ai]

Can you show size-limit --why output?

[bniwredyc]

Confirmed, something went wrong. I think I modified something inside node_modules and forgot about it. Will fix it soon. Sorry.

[bniwredyc]

Found the problem: I indeed modified the babel's typeof helper (used for the Symbol support) inside node_modules.
So, to disable typeof transformation, I replaced es2015 preset with a set of its plugins without transform-es2015-typeof-symbol.
Double-checked a clean repository clone - everything seems to be working now.
c8d736d

[ai]

=^_^= waiting for release