Skip to content

Commit

Permalink
pythongh-117482: Expand Tests for Slot Wrappers of Inherited Slots of…
Browse files Browse the repository at this point in the history
… Static Builtin Types (pythongh-122192)

(cherry picked from commit 33d32fa)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
  • Loading branch information
ericsnowcurrently authored and miss-islington committed Jul 23, 2024
1 parent 77ab53a commit e4d5279
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 10 deletions.
27 changes: 27 additions & 0 deletions Lib/test/test_embed.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from collections import namedtuple
import contextlib
import io
import json
import os
import os.path
Expand Down Expand Up @@ -415,6 +416,32 @@ def test_datetime_reset_strptime(self):
out, err = self.run_embedded_interpreter("test_repeated_init_exec", code)
self.assertEqual(out, '20000101\n' * INIT_LOOPS)

def test_static_types_inherited_slots(self):
slots = []
script = ['import sys']
from test.test_types import iter_builtin_types, iter_own_slot_wrappers
for cls in iter_builtin_types():
for slot in iter_own_slot_wrappers(cls):
slots.append((cls, slot))
attr = f'{cls.__name__}.{slot}'
script.append(f'print("{attr}:", {attr}, file=sys.stderr)')
script.append('')
script = os.linesep.join(script)

with contextlib.redirect_stderr(io.StringIO()) as stderr:
exec(script)
expected = stderr.getvalue().splitlines()

out, err = self.run_embedded_interpreter("test_repeated_init_exec", script)
results = err.split('--- Loop #')[1:]
results = [res.rpartition(' ---\n')[-1] for res in results]

self.maxDiff = None
for i, result in enumerate(results, start=1):
with self.subTest(loop=i):
self.assertEqual(result.splitlines(), expected)
self.assertEqual(out, '')


@unittest.skipIf(_testinternalcapi is None, "requires _testinternalcapi")
class InitConfigTests(EmbeddingTestsMixin, unittest.TestCase):
Expand Down
49 changes: 39 additions & 10 deletions Lib/test/test_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,26 @@ def clear_typing_caches():
f()


def iter_builtin_types():
for obj in __builtins__.values():
if not isinstance(obj, type):
continue
cls = obj
if cls.__module__ != 'builtins':
continue
yield cls


@cpython_only
def iter_own_slot_wrappers(cls):
for name, value in vars(cls).items():
if not name.startswith('__') or not name.endswith('__'):
continue
if 'slot wrapper' not in str(value):
continue
yield name


class TypesTests(unittest.TestCase):

def test_truth_values(self):
Expand Down Expand Up @@ -2361,24 +2381,33 @@ def setUpClass(cls):
def test_slot_wrappers(self):
rch, sch = interpreters.channels.create()

# For now it's sufficient to check int.__str__.
# See https://github.com/python/cpython/issues/117482
# and https://github.com/python/cpython/pull/117660.
script = textwrap.dedent('''
text = repr(int.__str__)
sch.send_nowait(text)
''')
slots = []
script = ''
for cls in iter_builtin_types():
for slot in iter_own_slot_wrappers(cls):
slots.append((cls, slot))
script += textwrap.dedent(f"""
text = repr({cls.__name__}.{slot})
sch.send_nowait(({cls.__name__!r}, {slot!r}, text))
""")

exec(script)
expected = rch.recv()
all_expected = []
for cls, slot in slots:
result = rch.recv()
assert result == (cls.__name__, slot, result[2]), (cls, slot, result)
all_expected.append(result)

interp = interpreters.create()
interp.exec('from test.support import interpreters')
interp.prepare_main(sch=sch)
interp.exec(script)
results = rch.recv()

self.assertEqual(results, expected)
for i, _ in enumerate(slots):
with self.subTest(cls=cls, slot=slot):
expected = all_expected[i]
result = rch.recv()
self.assertEqual(result, expected)


if __name__ == '__main__':
Expand Down

0 comments on commit e4d5279

Please sign in to comment.