Skip to content

Commit

Permalink
pythongh-48241: Clarify URL needs to be encoded when provided to urlo…
Browse files Browse the repository at this point in the history
…pen and Request (python#103855)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
  • Loading branch information
mblahay and ambv authored Apr 26, 2023
1 parent e901588 commit 44010d0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Doc/library/urllib.request.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ The :mod:`urllib.request` module defines the following functions:

.. function:: urlopen(url, data=None[, timeout], *, cafile=None, capath=None, cadefault=False, context=None)

Open the URL *url*, which can be either a string or a
:class:`Request` object.
Open *url*, which can be either a string containing a valid, properly
encoded URL, or a :class:`Request` object.

*data* must be an object specifying additional data to be sent to the
server, or ``None`` if no such data is needed. See :class:`Request`
Expand Down Expand Up @@ -192,7 +192,7 @@ The following classes are provided:

This class is an abstraction of a URL request.

*url* should be a string containing a valid URL.
*url* should be a string containing a valid, properly encoded URL.

*data* must be an object specifying additional data to send to the
server, or ``None`` if no such data is needed. Currently HTTP
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Clarifying documentation about the url parameter to urllib.request.urlopen and urllib.request.Requst needing to be encoded properly.

0 comments on commit 44010d0

Please sign in to comment.