Multiple --define arguments dies with an opaque error

[perimosocordiae]

Repro:

$ uglifyjs test.js -c -d FOO=true -d BAR=true

/usr/local/share/npm/lib/node_modules/uglify-js/bin/uglifyjs:358
        ast.walk(new UglifyJS.TreeWalker(function(node){
            ^
TypeError: Cannot call method 'walk' of undefined
    at getOptions (/usr/local/share/npm/lib/node_modules/uglify-js/bin/uglifyjs:358:13)
    at Object.<anonymous> (/usr/local/share/npm/lib/node_modules/uglify-js/bin/uglifyjs:125:42)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:901:3

Of course, the correct calling syntax works (-d FOO=true,BAR=true), but there should be a better error message for this case.

[rjmunro]

It took me ages to work out what was wrong here. I haven't seen anywhere where the comma separated syntax is documented.

[rvanvelzen]

Optionally you can pass a comma-separated list of options.

Not as clear as one would like, but it is there.

[ajcerqueti]

I am getting this same error from ~2.4.18 and up, but seems fine 2.4.17 and down. I'm using it as part of my Assetic stack under Symfony2, so I'm not manually adding any parameters etc, but from the error, it seems to be running the command:

uglifyjs --no-mangle -o /tmp/output29sOg5 /tmp/inputJn3rr2

Very eager to help fix this, can happily create a small Symfony2 repo and installation instructions to help someone replicate it.

[rubijn]

Same error in a Symfony2 project with 2.4.19 version on assetic:dump
uglifyjs --no-mangle -o /tmp/outputF2WY6Q /tmp/input83KyXz

But also in simple command line with any js in project
uglifyjs --no-mangle -o ./tmp/foo-ugli.js web/foo.js

With foo.js

 function foo() {
    console.log("foo");
}

/usr/lib/node_modules/uglify-js/bin/uglifyjs:485
        ast.walk(new UglifyJS.TreeWalker(function(node){
            ^
TypeError: Cannot call method 'walk' of undefined
    at getOptions (/usr/lib/node_modules/uglify-js/bin/uglifyjs:485:13)
    at Object.<anonymous> (/usr/lib/node_modules/uglify-js/bin/uglifyjs:161:14)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:935:3

node v0.10.38
nmp 1.4.28
uglifyjs 2.4.19

[mishoo]

@rubijn, @ajcerqueti — Guys, there is no --no-mangle flag in UglifyJS2. Just don't pass --mangle (or -m) and it will not mangle. Sorry if 2.4.17 and earlier used to ignore unknown arguments, that might have been an yargs “feature” (I upgraded yargs now). But I repeat: there is no --no-mangle flag, and never has been in UglifyJS2. Also, seems this has nothing to do with this ticket.

[ajcerqueti]

@mishoo - apologies. On first examination of this issue, it looked to the same error I was experiencing.

In actuality, this is an error/issue with Assetic, or at least the documentation of Symfony, which recommends UglifyJS, but npm installs the latest version, which is in fact UglifyJS2. This worked without issue up until 2.4.18, where the unknown arguments were ignored. There is already a filter in Assetic to use UglifyJS2 correctly, this just needs changes in the Symfony2 docs/cookbook.

@rubijn - change your filter name to uglifyjs2
https://github.com/symfony/AsseticBundle/blob/master/Resources/config/filters/uglifyjs2.xml

    filters:
    uglifyjs2:
        bin: %kernel.root_dir%/../node_modules/uglify-js/bin/uglifyjs
        apply_to: "\.js$"

[rubijn]

@mishoo ok sorry about that.
I 'will check the package in Symfony who use this non existant flag.
@ajcerqueti thanks

[leggiero]

I had the same issue because I used "uglifyjs" as filter.
Changing the filter to "uglifyjs2" as @ajcerqueti said, solved the issue.

"--no-mangle" is a command option of uglifyjs filter (not uglifyjs2), as you can see on:
https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Filter/UglifyJsFilter.php#L119
Uglifyjs2 filter doesn't use the "--no-mangle" option, as you can see here:
https://github.com/kriswallsmith/assetic/blob/master/src/Assetic/Filter/UglifyJsFilter.php

Thank you @ajcerqueti !

[alexlamsl]

Specifying multiple --define now works

$ echo 'console.log(FOO,!BAR)' | uglifyjs -c -d FOO=true -d BAR=true
console.log(!0,!1);