chore: migrate to owl bot (googleapis#834)

* chore: migrate to owl bot

* chore: copy files from googleapis-gen fb91803ccef5d7c695139b22788b309e2197856b

* chore: run the post processor

* 🦉 Updates from OwlBot

* chore: update post processor docker image

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

.github/.OwlBot.lock.yaml

@@ -0,0 +1,4 @@
+docker:
+  digest: sha256:f556e6e7be625deb1b2429fe608df27be57185c3e6b7d39ee0059f1609f17530
+  image: gcr.io/repo-automation-bots/owlbot-nodejs:latest  
+

.github/.OwlBot.yaml

@@ -0,0 +1,28 @@
+# Copyright 2021 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+docker:
+  image: gcr.io/repo-automation-bots/owlbot-nodejs:latest
+
+
+deep-remove-regex:
+  - /owl-bot-staging
+
+deep-copy-regex:
+  - source: /google/datastore/(v.*)/.*-nodejs/(.*)
+    dest: /owl-bot-staging/$1/$2
+  - source: /google/datastore/(admin/v.*)/.*-nodejs/(.*)
+    dest: /owl-bot-staging/$1/$2
+
+begin-after-commit-hash: fb91803ccef5d7c695139b22788b309e2197856b
+

.github/generated-files-bot.yml

@@ -0,0 +1,16 @@
+generatedFiles:
+- path: '.kokoro/**'
+  message: '`.kokoro` files are templated and should be updated in [`synthtool`](https://github.com/googleapis/synthtool)'
+- path: '.github/CODEOWNERS'
+  message: 'CODEOWNERS should instead be modified via the `codeowner_team` property in .repo-metadata.json'
+- path: '.github/workflows/**'
+  message: '`.github/workflows` (GitHub Actions) should be updated in [`synthtool`](https://github.com/googleapis/synthtool)'
+- path: '.github/generated-files-bot.+(yml|yaml)'
+  message: '`.github/generated-files-bot.(yml|yaml)` should be updated in [`synthtool`](https://github.com/googleapis/synthtool)'
+- path: 'README.md'
+  message: '`README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/master/.readme-partials.yaml'
+- path: 'samples/README.md'
+  message: '`samples/README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/master/.readme-partials.yaml'
+ignoreAuthors:
+- 'gcf-owl-bot[bot]'
+- 'yoshi-automation'

.github/workflows/ci.yaml

@@ -24,11 +24,6 @@ jobs:
       - run: rm -rf node_modules
       - run: npm install
       - run: npm test
-      - name: coverage
-        uses: codecov/codecov-action@v1
-        with:
-          name: actions ${{ matrix.node }}
-          fail_ci_if_error: false
   windows:
     runs-on: windows-latest
     steps:
@@ -38,11 +33,6 @@ jobs:
           node-version: 14
       - run: npm install
       - run: npm test
-      - name: coverage
-        uses: codecov/codecov-action@v1
-        with:
-          name: actions windows
-          fail_ci_if_error: false
   lint:
     runs-on: ubuntu-latest
     steps:

owlbot.py

@@ -0,0 +1,59 @@
+# Copyright 2021 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import synthtool as s
+import synthtool.gcp as gcp
+import synthtool.languages.node as node
+import logging
+from pathlib import Path
+from synthtool import _tracked_paths
+import shutil
+
+logging.basicConfig(level=logging.DEBUG)
+
+staging = Path("owl-bot-staging")
+
+if staging.is_dir():
+    logging.info(f"Copying files from staging directory ${staging}.")
+
+    # Copy the datastore library.
+    for version in ['v1']:
+        library = staging / version
+        _tracked_paths.add(library)
+        s.copy([library],excludes=[
+            'package.json', 'README.md', 'src/index.ts', 'src/v1/index.ts'])
+
+    # Copy the admin library.
+    for version in ['v1']:
+        library = staging / 'admin' / version
+        _tracked_paths.add(library)
+        s.copy([library],excludes=[
+            'package.json', 'README.md', 'src/index.ts', 'src/v1/index.ts', 'tsconfig.json', 'tslint.json',
+              'system-test/fixtures/sample/src/index.ts', 'system-test/fixtures/sample/src/index.js',
+              '.jsdoc.js', 'webpack.config.js'])
+
+    # Patch the code.
+    system_test_files = ['system-test/fixtures/sample/src/index.ts', 'system-test/fixtures/sample/src/index.js']
+    for file in system_test_files:
+        s.replace(file, 'DatastoreClient', 'Datastore')
+        s.replace(file, 'client.close', '// client.close'); # does not work with the manual layer
+
+    # The staging directory should never be merged into the main branch.
+    shutil.rmtree(staging)
+
+common_templates = gcp.CommonTemplates()
+templates = common_templates.node_library(source_location="build/src")
+s.copy(templates)
+
+node.postprocess_gapic_library_hermetic()

src/entity.ts

@@ -364,7 +364,7 @@ export namespace entity {
           isDsInt(identifier) ||
           isDsIntLike(identifier)
         ) {
-          this.id = (((identifier as {}) as Int).value || identifier) as string;
+          this.id = ((identifier as {} as Int).value || identifier) as string;
         } else if (is.string(identifier)) {
           this.name = identifier as string;
         }

src/request.ts

@@ -849,9 +849,8 @@ class DatastoreRequest {
       try {
         await Promise.all(
           arrify(entities).map(async (objEntity: Entity) => {
-            const obj: Entity = DatastoreRequest.prepareEntityObject_(
-              objEntity
-            );
+            const obj: Entity =
+              DatastoreRequest.prepareEntityObject_(objEntity);
             const [data] = await transaction.get(obj.key);
             obj.method = 'upsert';
             obj.data = Object.assign({}, data, obj.data);

src/v1/datastore_admin_client.ts

@@ -353,13 +353,14 @@ export class DatastoreAdminClient {
     ];
     for (const methodName of datastoreAdminStubMethods) {
       const callPromise = this.datastoreAdminStub.then(
-        stub => (...args: Array<{}>) => {
-          if (this._terminated) {
-            return Promise.reject('The client has already been closed.');
-          }
-          const func = stub[methodName];
-          return func.apply(stub, args);
-        },
+        stub =>
+          (...args: Array<{}>) => {
+            if (this._terminated) {
+              return Promise.reject('The client has already been closed.');
+            }
+            const func = stub[methodName];
+            return func.apply(stub, args);
+          },
         (err: Error | null | undefined) => () => {
           throw err;
         }
@@ -515,11 +516,10 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     this.initialize();
     return this.innerApiCalls.getIndex(request, options, callback);
   }
@@ -651,11 +651,10 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     this.initialize();
     return this.innerApiCalls.exportEntities(request, options, callback);
   }
@@ -818,11 +817,10 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     this.initialize();
     return this.innerApiCalls.importEntities(request, options, callback);
   }
@@ -976,11 +974,10 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     this.initialize();
     return this.innerApiCalls.createIndex(request, options, callback);
   }
@@ -1129,11 +1126,10 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     this.initialize();
     return this.innerApiCalls.deleteIndex(request, options, callback);
   }
@@ -1263,11 +1259,10 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     this.initialize();
     return this.innerApiCalls.listIndexes(request, options, callback);
   }
@@ -1304,11 +1299,10 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     const callSettings = new gax.CallSettings(options);
     this.initialize();
     return this.descriptors.page.listIndexes.createStream(
@@ -1356,17 +1350,16 @@ export class DatastoreAdminClient {
     options = options || {};
     options.otherArgs = options.otherArgs || {};
     options.otherArgs.headers = options.otherArgs.headers || {};
-    options.otherArgs.headers[
-      'x-goog-request-params'
-    ] = gax.routingHeader.fromParams({
-      project_id: request.projectId || '',
-    });
+    options.otherArgs.headers['x-goog-request-params'] =
+      gax.routingHeader.fromParams({
+        project_id: request.projectId || '',
+      });
     options = options || {};
     const callSettings = new gax.CallSettings(options);
     this.initialize();
     return this.descriptors.page.listIndexes.asyncIterate(
       this.innerApiCalls['listIndexes'] as GaxCall,
-      (request as unknown) as RequestType,
+      request as unknown as RequestType,
       callSettings
     ) as AsyncIterable<protos.google.datastore.admin.v1.IIndex>;
   }