Update search.cam.ac.uk URL to be https:// instead of http:// #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one's Drupal site uses https, Chrome (and possibly other browsers) refuse to mark the page as "secure" because 'The page includes a form with a non-secure action" attribute' - specifically, the search box. As of Chrome v62 (due for release October 17th), using any <input> element on a http:// site will lead to a security warning, hence PL sites may well be aiming to switch to https:// before then.
|
Would we be better just dropping the protocol ? |
|
http://search.cam.ac.uk auto-redirects to https://search.cam.ac.uk . The main reason for using protocol-relative URLs is when one wants to be able to use both http:// and https:// on the same site, but IMO when a site is https-only (as search.cam.ac.uk is) there's no benefit to PRURLs - and now that search.cam.ac.uk is https, they're unlikely to go back to http I'd have thought. |
|
Fair enough. I was coming from a simpler is better point of view, but I've no strong feelings on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one's Drupal site uses https, Chrome (and possibly other browsers) refuse to
mark the page as "secure" because 'The page includes a form with a non-secure
action" attribute' - specifically, the search box. As of Chrome v62 (due for
release October 17th), using any element on a http:// site will lead
to a security warning, hence PL sites may well be aiming to switch to https://
before then.