Repository navigation
Conversation
Every notification was pinned to the single channel configured at init time, so apps defining multiple channels couldn't route individual notifications to them. NotifierBuilder now takes an optional channelId; if that channel doesn't exist on the device we log a warning and fall back to the default channel.
Author
|
#157 also touches this area, with a different approach: it routes via a payload key and defines all channels up front in the config (replacing This PR is additive instead: the builder-level |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently local notification now goes into the one channel that is configured at initialization (
NotificationChannelData.id). Any application that creates multiple channels for notifications on Android has no way to route a particular notification.This adds an optional
channelIdtoNotifierBuilder:localNotifier.notify { channelId = "my_channel" title = "..." }If the channel does not exist on the device (or API < 26), we log a warning and fall back to the configured default channel to ensure nothing breaks silently. The behavior remains the same if
channelIdis left null.