Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 293: use python represenation of enum values for default values in schema #482

Closed
wants to merge 1 commit into from

Conversation

rafalp
Copy link
Contributor

@rafalp rafalp commented Mar 2, 2021

Fixes #293

This PR updates EnumType to scan schema for fields where Enum is used for value, and default value is defined.

TODO

  • Handle fields args field(arg: Enum = DEFAULT)
  • Handle inputs fields arg: Enum = DEFAULT
  • Handle fields inputs args field(arg: {field: DEFAULT})
  • Nested field inputs args field(arg: {child: {field: DEFAULT}})
  • Write tests
  • Cleanup the code

@rafalp rafalp added this to the Ariadne 0.13 milestone Mar 2, 2021
@rafalp rafalp self-assigned this Mar 2, 2021
@rafalp rafalp marked this pull request as draft March 3, 2021 10:13
@rafalp rafalp changed the title WIP: Fix: 293: use python represenation of enum values for default values in schema Fix: 293: use python represenation of enum values for default values in schema Mar 3, 2021
@rafalp rafalp removed this from the Ariadne 0.13 milestone Mar 4, 2021
@rafalp
Copy link
Contributor Author

rafalp commented Dec 3, 2021

Superseded by #533

@rafalp rafalp closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_executable_schema's omits default enum values in args and inputs
1 participant