feat(core): Enum.getDeclaringClass #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds: - Class.getName() - Class.forName(? extends Enum) - String.matches() ref: #923 Signed-off-by: Nils Brugger <nilsbrugger.nb.nb.nb@gmail.com>
mirkosertic
reviewed
Jun 5, 2023
nbrugger-tgm
commented
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds:
closes: #923
What i did here works (for JS not WASM), but i touched you reflection implementation. I pushed it quite a bit but I am not sure if this is the way you intended this to be used and also there might be more elegant ways to do what I did to
newRuntimeClass()andClass.getName()