Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple view for single fields #26

Closed
wants to merge 5 commits into from

Conversation

vcg-development
Copy link

This PR adds a minimalistic view if you just need a single repeatable field instead of a group of fields.

simpleview

Copy link
Owner

@mireo91 mireo91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From this commit I see only changes on Readme
nothing else was changed

@vcg-development
Copy link
Author

@mireo91 I'm sorry. I forgot to push the changes. It should be visible now. :)

@vcg-development vcg-development requested a review from mireo91 May 13, 2024 12:33
@jonnitto
Copy link
Contributor

Nice one

@mireo91
Copy link
Owner

mireo91 commented May 14, 2024

I will review and merge this weekend

@vcg-development
Copy link
Author

@jonnitto Done

Co-authored-by: Jon Uhlmann <account@uhlmann.pro>
@vcg-development
Copy link
Author

@jonnitto Is there still something I can improve or is it ready to be merged?

@jonnitto
Copy link
Contributor

No, we've to wait for @mireo91

@mireo91
Copy link
Owner

mireo91 commented Jun 18, 2024

@jonnitto as I understand you tested it on your side (I dont have much time to see it myself - my wife got pregnant and I am renovating house after work) could you confirm me that it is safe to marge without my involvement - I will do it then right away.

@jonnitto
Copy link
Contributor

@vcg-development The fields looks a bit unaligned. I think there is some more CSS work needed…

CleanShot.2024-06-18.at.12.55.08.mp4

@vcg-development
Copy link
Author

@vcg-development The fields looks a bit unaligned. I think there is some more CSS work needed…

CleanShot.2024-06-18.at.12.55.08.mp4

We'll have a look at it.

@vcg-development
Copy link
Author

@jonnitto I just tried to fix the problem but it's looking good on my end. Can you please send me an example yaml property so I can test it?

@jonnitto
Copy link
Contributor

@vcg-development If it ok for you I would integrate this into this PR #28

jonnitto added a commit to jonnitto/RepeatableFields that referenced this pull request Oct 16, 2024
@jonnitto jonnitto mentioned this pull request Oct 16, 2024
14 tasks
@vcg-development
Copy link
Author

Sure. Thank you!

@jonnitto
Copy link
Contributor

Sure. Thank you!

Already done 😉

@jonnitto
Copy link
Contributor

@mireo91 When #28 is merged, you can close this one

@mireo91 mireo91 closed this Oct 29, 2024
@mireo91
Copy link
Owner

mireo91 commented Oct 29, 2024

@vcg-development new release v2.2.2 should contain your modifications https://github.com/mireo91/RepeatableFields/releases/tag/v2.2.2
Many thanks and sorry for delays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants