-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added simple view for single fields #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From this commit I see only changes on Readme
nothing else was changed
@mireo91 I'm sorry. I forgot to push the changes. It should be visible now. :) |
Nice one |
I will review and merge this weekend |
Resources/Private/Backend/RepeatableField/src/View/Repeatable.js
Outdated
Show resolved
Hide resolved
@jonnitto Done |
Resources/Private/Backend/RepeatableField/src/View/Repeatable.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Jon Uhlmann <account@uhlmann.pro>
@jonnitto Is there still something I can improve or is it ready to be merged? |
No, we've to wait for @mireo91 |
@jonnitto as I understand you tested it on your side (I dont have much time to see it myself - my wife got pregnant and I am renovating house after work) could you confirm me that it is safe to marge without my involvement - I will do it then right away. |
@vcg-development The fields looks a bit unaligned. I think there is some more CSS work needed… CleanShot.2024-06-18.at.12.55.08.mp4 |
We'll have a look at it. |
@jonnitto I just tried to fix the problem but it's looking good on my end. Can you please send me an example yaml property so I can test it? |
@vcg-development If it ok for you I would integrate this into this PR #28 |
Sure. Thank you! |
Already done 😉 |
@vcg-development new release v2.2.2 should contain your modifications https://github.com/mireo91/RepeatableFields/releases/tag/v2.2.2 |
This PR adds a minimalistic view if you just need a single repeatable field instead of a group of fields.