Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasource: Add typealias StateData #216

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Datasource: Add typealias StateData #216

merged 1 commit into from
Feb 2, 2024

Conversation

hugolefrancois
Copy link
Contributor

Description

Add a typealias StateData to DataState to avoid having to always specify the error type

Motivation and Context

Less keystrokes more thinking :wesmart:

How Has This Been Tested?

In my project

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

npresseault
npresseault approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@npresseault npresseault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont forget to apiDump

@hugolefrancois hugolefrancois merged commit 9112044 into master Feb 2, 2024
1 check passed
@hugolefrancois hugolefrancois deleted the feature/statedata branch February 2, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npresseault npresseault npresseault approved these changes

@gbourassa gbourassa Awaiting requested review from gbourassa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugolefrancois @npresseault