Remove deprecated Foundation.Date in internal modules #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuLegault1
commented
Jan 5, 2024
MathieuLegault1
force-pushed
the
feature/use-kotlinx-datetime
branch
from
5f9c9b3
to
f64c949
Compare
npresseault
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We already deprecated the use of trikot
Foundation.Datebut some modules were still using it (internally). This PR changes those usage forkotlinx-datetime.Motivation and Context
Since removing it internally doesn't affect the api that we expose there is no reason not to remove it. It could be useful if we ever decide to hard deprecate it also
How Has This Been Tested?
This was tested using the already existing unit test
Types of changes