Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS VMD Flow] Change how we handle image error #187

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

hugolefrancois
Copy link
Contributor

Description

The current way to know if an VMDImage "remote" image has failed to load wasn't working. The .placeholder modifier is not triggered again when the @State of the VMDImage changed. To fix that, I have use an environment variable to expose that stat outside of the VMDImage. That environment variable is then accessible in the placeholder view.

Unfortunately, I have to make a breaking change to remove the .placeholder modifier with the param that is not working and I also had to remove the "empty" value of the LoadingStatus enum because this state wasn't really possible.

How Has This Been Tested?

On my project and in Sample app

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@hugolefrancois hugolefrancois merged commit 3d449d9 into master Sep 26, 2023
1 check passed
@hugolefrancois hugolefrancois deleted the fix/ios_image_error branch September 26, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants