Dispatch Android Lifecycle addObserver and removeObserver on main thread #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarochelle
changed the title
gbourassa
approved these changes
Aug 24, 2023
marcantoinefortier
approved these changes
Aug 25, 2023
marcantoinefortier
approved these changes
Aug 25, 2023
| @@ -21,11 +22,17 @@ actual class ApplicationStatePublisher : | |||
|
|
|||
| override fun onFirstSubscription() { | |||
| super.onFirstSubscription() | |||
| lifecycle.addObserver(this) | |||
|
|
|||
| UIThreadDispatchQueue().dispatch { | |||
There was a problem hiding this comment.
We could reuse the same dispatch queue for both methods, but that's fine like that too 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android
Lifecycle::addObserverandLifecycle::removeObservershould only be called on the main thread, this PR makes sure that these functions are always called on the main thread.Motivation and Context
This was somewhat unclear in Trikot and could cause crashes in apps subscribing to the ApplicationStatePublisher when subscribing/unsubscribing. Trikot should make sure that these functions are called from the main thread.
How Has This Been Tested?
Tested in my application.
Types of changes