Lowering Android min SDK to 21 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npresseault
approved these changes
Apr 25, 2023
| lint { | ||
| abortOnError = true | ||
| checkReleaseBuilds = true | ||
| disable.add("NotificationPermission") |
There was a problem hiding this comment.
there is no way to have this on a more granular level?
There was a problem hiding this comment.
Possibly, but it's the sample project(s), so I'd say it's good enough.
For more context, this is a weird linting issue triggered by Picasso following the update of the Gradle plugin. Updating Picasso version may have helped, but it seemed less risky to simply disable the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trikot should try to keep minimum android version requirements as low as possible, so that legacy projects that still use 21 as their min SDK can use it.
There is nothing in the code that actually requires a min SDK of 24.
Motivation and Context
Some older projects still have their min SDK set at 21, and this should not prevent us from including Trikot.
How Has This Been Tested?
Android samples are still running, all check tasks still pass, lib can be included in a 21+ project with success.
Types of changes