[VMD-Compose] Fixed observe of a single field of a ViewModel without specifying an initial value explicitly. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specifying an initial value explicitly. (calling the getter now requires "this" as a param)
npresseault
approved these changes
Apr 6, 2023
npresseault
added a commit
that referenced
this pull request
May 17, 2023
Since #158 it was no longer possible to call observe as state using a KProperty0 (class property without a receiver). We now properly support KProperty0 (class property) and KProperty1 (instance property with a receiver) For reference val kPropReceiver: KProperty0<Boolean> = viewModel::isHidden val kProp: KProperty1<VMDViewModel, Boolean> = VMDViewModel::isHidden KProperty2: extension function with a different receiver will not be supported.
3 tasks
npresseault
added a commit
that referenced
this pull request
May 17, 2023
Description The exception thrown was: Fatal Exception: java.lang.IllegalArgumentException: Callable expects 0 arguments, but 1 were provided. Since #158 it was no longer possible to call observeAsState using a KProperty0 (instance property). We now properly support KProperty0 (instance property) and KProperty1 (class property with a receiver argument) For reference val kPropReceiver: KProperty0<Boolean> = viewModel::isHidden val kProp: KProperty1<VMDViewModel, Boolean> = VMDViewModel::isHidden KProperty2: extension function with a different receiver will not be supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this case, reflection is used to call the getter. Calling it without any parameters doesn't work anymore, probably following an update of the Kotlin version at some point.
Adding the required param to the getter.
Motivation and Context
Attempting to observe a single field without an initial value (which is optional) resulted in a crash:
How Has This Been Tested?
In a project.
Types of changes