MMSW-13526: Enable async mode by default for FTVE devices #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Problem] There are frame drops and performance issues with 60fps content on some Amazon SmartTv (FTVE) devices. [Solution] We identified that switching the MediaCodec APIs to asynchronous buffer queueing mode improves the performance and reduces frame drops. We enable async mode by default for FTVE devices with API level >= 28. Developers still have the option to disable async mode with DefaultRenderersFactory.forceDisableMediaCodecAsynchronousQueueing() if they wish to do so. cr: https://code.amazon.com/reviews/CR-92572712
SylvainMorel
approved these changes
Feb 21, 2024
Merged
jdtremblay
added a commit
that referenced
this pull request
Apr 23, 2024
We found an issue when CC are enabled that was causing video freezes. The root cause of the issue is somewhat similar to the one that's been fixed in #11. In this case, the TextRenderer (CCs) blocks the period transitions because it's not done reading its input buffer until it's a bit too late. We have a cue every frame, which means 60 cues per second in live. The CEA codec has a pool of 10 input buffers, and the TextRenderer reads its buffer and sends it pretty much directly to the codec. That means the renderer can only deplete its input buffer approximately 0.17 secs before the end of the period. This is a bit tight on some platform(s), and can cause audio buffer underruns, which in turn causes video freezes, and can even cause some sort of rendering deadlocks on said platform(s). This PR Increases the CEA decoder input buffers count to 100. That way the TextRenderer is very unlikely to be the one blocking the period transition. In my tests, it went back to being the video renderer always the last to be ready to transition to the next period.
jdtremblay
added a commit
that referenced
this pull request
Apr 23, 2024
We found an issue when CC are enabled that was causing video freezes. The root cause of the issue is somewhat similar to the one that's been fixed in #11. In this case, the TextRenderer (CCs) blocks the period transitions because it's not done reading its input buffer until it's a bit too late. We have a cue every frame, which means 60 cues per second in live. The CEA codec has a pool of 10 input buffers, and the TextRenderer reads its buffer and sends it pretty much directly to the codec. That means the renderer can only deplete its input buffer approximately 0.17 secs before the end of the period. This is a bit tight on some platform(s), and can cause audio buffer underruns, which in turn causes video freezes, and can even cause some sort of rendering deadlocks on said platform(s). This PR Increases the CEA decoder input buffers count to 100. That way the TextRenderer is very unlikely to be the one blocking the period transition. In my tests, it went back to being the video renderer always the last to be ready to transition to the next period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bring a fix made by Amazon on their exoplayer-amazon-port.
Original description
[Problem]
There are frame drops and performance issues with 60fps content on some Amazon SmartTv (FTVE) devices.
[Solution]
We identified that switching the MediaCodec APIs to asynchronous buffer queueing mode improves the performance and reduces frame drops. We enable async mode by default for FTVE devices with API level >= 28. Developers still have the option to disable async mode with DefaultRenderersFactory.forceDisableMediaCodecAsynchronousQueueing() if they wish to do so.
cr: https://code.amazon.com/reviews/CR-92572712