Fix : replaced all occurrences of placeholders in document target path - #504
Open
stefanwakata wants to merge 2 commits into
Open
Fix : replaced all occurrences of placeholders in document target path#504stefanwakata wants to merge 2 commits into
stefanwakata wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #496
The ".replace()" calls in "document-jipt-paths-fetcher.ts" and "document-paths-fetcher.ts" only replaced the first match of each placeholder (%slug%, %original_file_name%, %document_path%), since a plain regex/string replace in JS stops after one hit. Added the "/g" flag so all occurrences get replaced.
Tested with the target pattern from the issue (
%document_path%/%document_path%.%slug%.resx), before this it produced "Description/%document_path%.de.resx", now it correctly produces "Description/Description.de.resx". Also ran "npm run build" and the CI checks on my fork, both green.