-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tags #527
base: master
Are you sure you want to change the base?
Add support for tags #527
Conversation
@coderabbitai review |
Actions PerformedReview triggered.
|
WalkthroughThis update introduces a new feature for managing wiki tags in the CreateWiki extension. It includes backend changes to handle wiki tags in the database and frontend enhancements for selecting tags via a user-friendly interface. The update also adds internationalization support for the new tags feature. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- extension.json (3 hunks)
- i18n/en.json (1 hunks)
- i18n/qqq.json (1 hunks)
- includes/RemoteWiki.php (3 hunks)
- includes/RequestWiki/SpecialRequestWiki.php (2 hunks)
- modules/ext.createwiki.oouiform.wikiTags.js (1 hunks)
- sql/cw_wikis.sql (1 hunks)
- sql/patches/patch-cw_wikis-add-wiki_tags.sql (1 hunks)
Files skipped from review due to trivial changes (2)
- i18n/qqq.json
- sql/cw_wikis.sql
Additional comments not posted (7)
sql/patches/patch-cw_wikis-add-wiki_tags.sql (1)
1-2
: The SQL patch correctly adds thewiki_tags
column to thecw_wikis
table with appropriate default settings.modules/ext.createwiki.oouiform.wikiTags.js (1)
1-38
: The JavaScript module for wiki tag selection is well-implemented, using efficient jQuery and OOUI components.includes/RequestWiki/SpecialRequestWiki.php (2)
52-61
: The addition of theext.createwiki.oouiform.wikiTags
module and configuration of JavaScript variables are correctly implemented.
106-113
: The form field for wiki tags is correctly added and configured based on the system settings.includes/RemoteWiki.php (1)
31-31
: Thewikitags
property and its associated getter and setter methods are correctly implemented in theRemoteWiki
class.Also applies to: 80-83, 332-344
extension.json (1)
184-193
: The newext.createwiki.oouiform.wikiTags
module and theCreateWikiAvailableTags
andCreateWikiUseWikiTags
configuration variables are correctly defined.Also applies to: 214-218, 390-394
i18n/en.json (1)
40-40
: The new message key"createwiki-label-wiki-tags": "Wiki tags"
is correctly added to the internationalization messages.
'type' => 'text', | ||
'label-message' => 'createwiki-label-wiki-tags', | ||
'cssclass' => 'createwiki-wikitags', | ||
'disabled' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be readonly => true
, no? Or else it won't be sent with the form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may be right. This still has a lot of work like also passing to cw_requests also
Summary by CodeRabbit
New Features
Enhancements
Localization
Database