Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an API endpoint to post comments to wiki requests #516

Closed
wants to merge 19 commits into from
Closed

Add an API endpoint to post comments to wiki requests #516

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
2ea6fe8
create RestWikiRequestComment
redbluegreenhat May 2, 2024
bf9db88
Merge remote-tracking branch 'upstream/master' into restwikirequestco…
redbluegreenhat May 2, 2024
dfaf560
fix
redbluegreenhat May 2, 2024
5ba5b57
fix
redbluegreenhat May 2, 2024
06172a3
fix
redbluegreenhat May 2, 2024
36a518a
Reorder checks
redbluegreenhat May 2, 2024
13f798c
Return UnsupportedContentTypeBodyValidator on non-JSON request bodies
redbluegreenhat May 2, 2024
a0adc18
fix
redbluegreenhat May 2, 2024
dcff2ca
add to extension.json
redbluegreenhat May 2, 2024
aa7c5a3
require safe against csrf
redbluegreenhat May 2, 2024
166bafc
return a proper response
redbluegreenhat May 2, 2024
a046e20
Merge remote-tracking branch 'upstream/master' into restwikirequestco…
redbluegreenhat May 2, 2024
324eb3d
Merge remote-tracking branch 'upstream/master' into restwikirequestco…
redbluegreenhat May 4, 2024
e08a590
update
redbluegreenhat May 4, 2024
a5ad4e8
reorder uses
redbluegreenhat May 4, 2024
6f2dbf9
Merge remote-tracking branch 'upstream/master' into restwikirequestco…
redbluegreenhat May 4, 2024
1e1ea8e
add i18n
redbluegreenhat May 4, 2024
fa38359
Merge remote-tracking branch 'upstream/master' into restwikirequestco…
redbluegreenhat May 14, 2024
1efd651
update
redbluegreenhat May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@redbluegreenhat
redbluegreenhat committed May 2, 2024
commit dfaf560667df22334727eae039310f29aefefb2c
6 changes: 3 additions & 3 deletions includes/RequestWiki/Handler/RestWikiRequestComment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@ public function run( $requestID ) {
return $this->getResponseFactory()->createLocalizedHttpError( 404, new MessageValue( 'requestwiki-unknown' ) );
}
// Must be logged in to use this API
if ( !$this->getAuthority->isNamed() ) {
if ( !$this->getAuthority()->isNamed() ) {
return $this->getResponseFactory()->createLocalizedHttpError( 403, new MessageValue( 'createwiki-rest-mustlogin' ) );
}
// Only allow users with (createwiki) the creator of the request to post comments
if ( !$this->getAuthority->isAllowed( 'createwiki' ) || $this->getAuthority()->getUser()->getId() !== $wikiRequest->requester->getId() )
if ( !$this->getAuthority()->isAllowed( 'createwiki' ) || $this->getAuthority()->getUser()->getId() !== $wikiRequest->requester->getId() )
return $this->getResponseFactory()->createLocalizedHttpError( 403, new MessageValue( 'createwiki-rest-notallowed' ) );
}
// Do not allow blocked users to post comments
if ( $this->getAuthority->getBlock() ) {
if ( $this->getAuthority()->getBlock() ) {
return $this->getResponseFactory()->createLocalizedHttpError( 403, new MessageValue( 'createwiki-rest-notallowed' ) );
}

Expand Down
Loading