-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop astring dependency #193
Conversation
this together with mirage-qubes 0.9.5 and xenstore 2.3.0 (both waiting on being merged to opam-repository) reduces the binary size of the firewall to 3.4MB. I'll update this PR once the above packages have been merged to opam-repository, and then update the checksum and call it ready :) |
Thank you! I propose to update Dockerfile once opam-repository PRs will be merged and merge both PRs into main. And sadly I see I conflicted |
Sounds good to me, I just force-pushed to remove the update of the hash here. Once opam-repository is fine, we can do as you suggested. |
Thanks to @dinosaure who merged the outstanding opam-repository PRs, I pushed an update to the opam-repo commit and wait for the checksum to materialize. |
Thank you that's perfect! |
and CI is green, so feel free to cut a release when you feel like doing so :) |
I'll run a couple of local tests and cut the new release. Thank you @hannesm |
Oups I got:
let total_size = max Request.sizeof_req Response.sizeof_resp
let () = assert(total_size = 12) And |
Appart from that issue (locally fixed by hand), all went well. So once the new release is merged in opam-repository, it should be ok to cut the release :) |
waiting for ocaml/opam-repository#25823, thanks for your testing and investigations! :) |
Dear @palainp, this is now updated to mirage-net-xen 2.1.5. Please feel free to test and merge and release :) |
Thank you, all is fine! |
No description provided.