Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop astring dependency #193

Merged
merged 6 commits into from
May 10, 2024
Merged

drop astring dependency #193

merged 6 commits into from
May 10, 2024

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Apr 24, 2024

No description provided.

@hannesm
Copy link
Member Author

hannesm commented May 6, 2024

this together with mirage-qubes 0.9.5 and xenstore 2.3.0 (both waiting on being merged to opam-repository) reduces the binary size of the firewall to 3.4MB. I'll update this PR once the above packages have been merged to opam-repository, and then update the checksum and call it ready :)

@palainp
Copy link
Member

palainp commented May 7, 2024

Thank you! I propose to update Dockerfile once opam-repository PRs will be merged and merge both PRs into main. And sadly I see I conflicted build-with.sh when I removed the space before the hashsum :(

@hannesm
Copy link
Member Author

hannesm commented May 7, 2024

Sounds good to me, I just force-pushed to remove the update of the hash here. Once opam-repository is fine, we can do as you suggested.

@hannesm
Copy link
Member Author

hannesm commented May 9, 2024

Thanks to @dinosaure who merged the outstanding opam-repository PRs, I pushed an update to the opam-repo commit and wait for the checksum to materialize.

@palainp
Copy link
Member

palainp commented May 9, 2024

Thank you that's perfect!

build-with.sh Outdated Show resolved Hide resolved
@hannesm
Copy link
Member Author

hannesm commented May 9, 2024

and CI is green, so feel free to cut a release when you feel like doing so :)

@palainp
Copy link
Member

palainp commented May 9, 2024

I'll run a couple of local tests and cut the new release. Thank you @hannesm

@palainp
Copy link
Member

palainp commented May 9, 2024

Oups I got:

[2024-05-09 15:15:11] Fatal error: exception File "duniverse/mirage-net-xen/lib/tX.ml", line 118, characters 9-15: Assertion failed

duniverse/mirage-net-xen/lib/tX.ml:118 is:

let total_size = max Request.sizeof_req Response.sizeof_resp
let () = assert(total_size = 12)

And Request.sizeof_req = 10 and Response.sizeof_resp=4, I missed that :(

@palainp
Copy link
Member

palainp commented May 9, 2024

Appart from that issue (locally fixed by hand), all went well. So once the new release is merged in opam-repository, it should be ok to cut the release :)

@hannesm
Copy link
Member Author

hannesm commented May 9, 2024

waiting for ocaml/opam-repository#25823, thanks for your testing and investigations! :)

@hannesm
Copy link
Member Author

hannesm commented May 10, 2024

Dear @palainp, this is now updated to mirage-net-xen 2.1.5. Please feel free to test and merge and release :)

@palainp
Copy link
Member

palainp commented May 10, 2024

Thank you, all is fine!

@palainp palainp merged commit 332b118 into mirage:main May 10, 2024
2 checks passed
@hannesm hannesm deleted the no-astring branch May 10, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants