Skip to content

Add config constructor in Prometheus_unix #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abbysmal
Copy link

This PR is a follow-up to our previous conversation offline.

This PR aims to add a simple constructor for the config type in Prometheus_unix, so that we do not have to solely rely on the Cmdliner based facility.

This is probably not quite nice enough, let me know if I can adjust it in any way. :)

@rbjorklin
Copy link

This looks related to my suggested change in #51, no?

@abbysmal
Copy link
Author

abbysmal commented Oct 19, 2022

If I understand correctly, it is not quite the same: The goal here is to produce an alternative constructor to the type config, in order to be able to bypass the usage of Cmdliner (not convenient for me at the moment).
From what I see, your PR extends the Cmdliner constructor with a new arbitrary bind address parameter.

I am however fine with waiting on your PR to be merged to include your changes to this PR, since our changes clashes nonetheless. :-)

Edit: my bad, I misread your sentence: it is not the same, but our changes are related indeed! If you feel like incorporating the config constructor outside of Cmdliner from my changes into your branch, feel free to do it! Or I will wait for your work to be merged and fix this branch myself. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants