Split implementation to a pure app #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulrikstrid
force-pushed
the
ulrikstrid--pure-implementation
branch
from
724d7a3 to
df232b1
Compare
talex5
reviewed
Aug 5, 2022
ulrikstrid
force-pushed
the
ulrikstrid--pure-implementation
branch
from
df232b1 to
5acd350
Compare
|
Sorry for the super late update here @talex5. I have now rebased, changed the name to |
talex5
reviewed
Oct 27, 2022
|
|
||
| The `prometheus-reporter.unix` ocamlfind library provides the `Prometheus_reporter_unix` module, | ||
| which includes a cmdliner option. | ||
| See the `examples/example.ml` program for an example, which can be run as: |
| @@ -0,0 +1,18 @@ | |||
| (** Report metrics for Prometheus. | |||
| See: https://prometheus.io/ | |||
There was a problem hiding this comment.
This was See: {{:https://prometheus.io/}https://prometheus.io/} previously.
| @@ -0,0 +1,55 @@ | |||
| (** Report metrics for Prometheus. | |||
| See: https://prometheus.io/ | |||
Comment on lines
+12
to
+20
| - This extends [Prometheus_reporter] with support for cmdliner option parsing, a server pre-configured | ||
| for Unix, and a start-time metric that uses [Unix.gettimeofday]. | ||
| *) | ||
|
|
||
| type config = int option | ||
|
|
||
| val opts : config Cmdliner.Term.t | ||
| (** [opts] is the extra command-line options to offer Prometheus | ||
| monitoring. *) |
There was a problem hiding this comment.
It might make more sense to keep the cmdliner stuff for cohttp in app. That would also avoid exposing the type (which is likely to change - see #51).
| process_cpu_seconds_total; | ||
| ] | ||
| end | ||
| include Prometheus_reporter |
There was a problem hiding this comment.
We should also be able to include it in the mli, to avoid duplication.
|
I would love to see a combination of Prometheus and Dream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty early PR that just moves the code around a bit to not depend on cohttp.
Tests seems to pass on my machine at least.
Closes #39