Custom percent-encoders: don't mutate base encoder #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment,
`Custom
mutates the safe character array of its underlying component kind:ocaml-uri/lib/uri.ml
Lines 166 to 176 in b4a8375
This was added in #147. I'm not sure if this is intentional or not (cc @orbitz). I am currently abusing
`Custom
to build IRI-like percent encoders from existing component kinds (as a workaround for lack of #34). I don't want to modify the underlying encoders, though — I'd like both IRI and ASCII-only support for my own code, and, in addition, I fear about violating the assumptions of other code linked into the program.